Back
[00:35:35] -!- kalxas has quit [Remote host closed the connection]
[00:37:41] -!- Tom_shop [Tom_shop!~Tom@ip68-102-196-26.ks.ok.cox.net] has joined #linuxcnc-devel
[01:45:40] -!- zeeshan [zeeshan!~kvirc64@CPE84948c379051-CM84948c379050.cpe.net.cable.rogers.com] has joined #linuxcnc-devel
[01:56:04] -!- kingarmadillo has quit [Ping timeout: 260 seconds]
[02:03:04] -!- Tom_shop has quit [Quit: Leaving]
[02:13:20] -!- remstw has quit [Ping timeout: 260 seconds]
[02:40:35] -!- zeeshan has quit [Quit: KVIrc 4.3.1 Aria http://www.kvirc.net/ - 64bit Windows version by http://kvirc.d00p.de/]
[03:09:55] -!- skunkworks has quit [Ping timeout: 256 seconds]
[04:24:28] -!- KGB-wlo has quit [Ping timeout: 260 seconds]
[04:25:48] -!- seb_kuzminsky has quit [Ping timeout: 244 seconds]
[04:25:52] -!- hm2-buildmaster_ has quit [Ping timeout: 250 seconds]
[04:26:14] -!- linuxcnc-build_ has quit [Ping timeout: 265 seconds]
[05:14:01] -!- KimK has quit [Ping timeout: 256 seconds]
[05:27:16] -!- KimK [KimK!~Kim__@2600:8803:7a85:6d00:9d95:cc4f:20d8:535b] has joined #linuxcnc-devel
[06:47:58] -!- mozmck has quit [Ping timeout: 256 seconds]
[07:23:12] -!- ve7it has quit [Remote host closed the connection]
[07:47:39] -!- mozmck [mozmck!~moses@67.210.159.94] has joined #linuxcnc-devel
[08:24:38] -!- mozmck has quit [Ping timeout: 245 seconds]
[08:25:20] -!- mozmck [mozmck!~moses@67.210.159.94] has joined #linuxcnc-devel
[08:28:39] -!- kwallace_ofcb [kwallace_ofcb!~kwallace@162.222.30.253] has parted #linuxcnc-devel
[08:32:44] -!- mozmck has quit [Ping timeout: 260 seconds]
[08:53:59] -!- kalxas has quit [Changing host]
[09:03:06] -!- testac3 has quit [Remote host closed the connection]
[09:38:37] wtsmer is now known as remstw
[09:57:45] -!- kingarmadillo has quit [Ping timeout: 252 seconds]
[10:13:55] -!- b_b has quit [Changing host]
[10:19:56] -!- sel [sel!~sel@net77-43-27-64.mclink.it] has joined #linuxcnc-devel
[10:23:32] -!- sel has quit [Client Quit]
[10:59:43] -!- kingarmadillo has quit [Ping timeout: 268 seconds]
[11:01:29] -!- mozmck [mozmck!~moses@67.210.159.94] has joined #linuxcnc-devel
[11:28:54] -!- hm2-buildmaster [hm2-buildmaster!~hm2-build@71-218-151-86.hlrn.qwest.net] has joined #linuxcnc-devel
[11:28:58] -!- seb_kuzminsky [seb_kuzminsky!~seb@71-218-151-86.hlrn.qwest.net] has joined #linuxcnc-devel
[11:28:58] -!- mode/#linuxcnc-devel [+v seb_kuzminsky] by ChanServ
[11:28:59] -!- linuxcnc-build [linuxcnc-build!~linuxcnc-@71-218-151-86.hlrn.qwest.net] has joined #linuxcnc-devel
[11:29:03] -!- KGB-wlo [KGB-wlo!~kgb-wlo@71-218-151-86.hlrn.qwest.net] has joined #linuxcnc-devel
[11:29:54] -!- hm2-buildmaster_ [hm2-buildmaster_!~hm2-build@71-218-152-90.hlrn.qwest.net] has joined #linuxcnc-devel
[11:31:05] -!- linuxcnc-build_ [linuxcnc-build_!~linuxcnc-@71-218-152-124.hlrn.qwest.net] has joined #linuxcnc-devel
[11:33:24] -!- KGB-wlo has quit [Ping timeout: 250 seconds]
[11:33:25] -!- seb_kuzminsky has quit [Ping timeout: 248 seconds]
[11:33:41] -!- linuxcnc-build has quit [Ping timeout: 256 seconds]
[11:33:41] -!- hm2-buildmaster has quit [Ping timeout: 256 seconds]
[11:33:57] -!- seb_kuzminsky [seb_kuzminsky!~seb@71-218-152-124.hlrn.qwest.net] has joined #linuxcnc-devel
[11:33:57] -!- mode/#linuxcnc-devel [+v seb_kuzminsky] by ChanServ
[11:33:59] -!- hm2-buildmaster [hm2-buildmaster!~hm2-build@71-218-152-124.hlrn.qwest.net] has joined #linuxcnc-devel
[11:34:08] -!- hm2-buildmaster_ has quit [Ping timeout: 256 seconds]
[11:40:15] -!- KGB-wlo [KGB-wlo!~kgb-wlo@71-218-152-124.hlrn.qwest.net] has joined #linuxcnc-devel
[12:59:49] -!- kingarmadillo has quit [Ping timeout: 256 seconds]
[13:08:05] -!- skunkworks [skunkworks!~skunkwork@str-broadband-ccmts-ws-26.dsl.airstreamcomm.net] has joined #linuxcnc-devel
[15:00:37] -!- kingarmadillo has quit [Ping timeout: 252 seconds]
[15:03:38] <cradek> on github I'm looking at
https://github.com/LinuxCNC/linuxcnc/commit/0da9a50f30bb575d557b6617fa0fb0b228216f43
[15:03:53] <cradek> I wanted to add a comment, so I clicked the square plus sign
[15:04:33] <cradek> it let me type my comment but then said "You can't perform this operation at this time"
[15:05:26] <cradek> oh wait, it worked the second time
[15:25:37] -!- kwallace_ofcb [kwallace_ofcb!~kwallace@162.222.30.253] has joined #linuxcnc-devel
[15:50:17] -!- terkaa [terkaa!~terkaa@a91-155-72-157.elisa-laajakaista.fi] has joined #linuxcnc-devel
[15:56:57] -!- terkaa has quit [Ping timeout: 268 seconds]
[15:58:47] -!- terkaa [terkaa!~terkaa@a91-155-72-157.elisa-laajakaista.fi] has joined #linuxcnc-devel
[15:59:07] -!- terkaa [terkaa!~terkaa@a91-155-72-157.elisa-laajakaista.fi] has parted #linuxcnc-devel
[15:59:08] -!- terkaa [terkaa!~terkaa@a91-155-72-157.elisa-laajakaista.fi] has joined #linuxcnc-devel
[15:59:32] <terkaa> hi
[16:18:11] -!- kirk_wallace [kirk_wallace!~kwallace@162.222.30.253] has joined #linuxcnc-devel
[16:34:17] -!- pragmaticus has quit [Ping timeout: 240 seconds]
[17:25:05] -!- persina has quit [Ping timeout: 260 seconds]
[17:32:05] -!- t4nk518 has quit [Ping timeout: 260 seconds]
[17:43:43] -!- terkaa has quit [Ping timeout: 256 seconds]
[17:48:26] -!- terkaa [terkaa!~terkaa@a91-155-72-157.elisa-laajakaista.fi] has joined #linuxcnc-devel
[18:22:20] -!- rigid has quit [Quit: NO WINE, NO WIFE, NO CARRIER]
[18:23:07] -!- rigid has quit [Changing host]
[18:24:17] -!- rigid has quit [Remote host closed the connection]
[18:24:59] -!- rigid has quit [Changing host]
[18:31:37] -!- rigid has quit [Quit: NO WINE, NO WIFE, NO CARRIER]
[18:34:46] -!- rigid has quit [Changing host]
[18:34:48] -!- rigid has quit [Remote host closed the connection]
[18:35:31] -!- rigid has quit [Changing host]
[18:40:41] -!- skunkworks has quit [Ping timeout: 260 seconds]
[18:54:31] -!- rigid has quit [Quit: NO WINE, NO WIFE, NO CARRIER]
[18:56:19] -!- rigid has quit [Changing host]
[18:57:40] -!- rigid has quit [Remote host closed the connection]
[18:58:56] -!- rigid has quit [Changing host]
[18:59:14] -!- rigid has quit [Remote host closed the connection]
[18:59:54] -!- rigid has quit [Changing host]
[19:12:27] <cradek> for(it++; it < settings->g71_blocks.end(); it++) {
[19:12:46] <cradek> wouldn't this skip the first thing?
[19:13:03] <jepler> if it = g71_blocks.begin() just before, yes.
[19:13:51] <cradek> oh, prev_motion = ...
[19:13:53] <cradek> it's on purpose
[19:14:02] <cradek> treats them pairwise
[19:14:15] <cradek> rtfc
[19:17:20] -!- skunkworks [skunkworks!~skunkwork@68-115-41-210.static.eucl.wi.charter.com] has joined #linuxcnc-devel
[19:18:46] -!- rigid has quit [Quit: NO WINE, NO WIFE, NO CARRIER]
[19:19:57] -!- rigid has quit [Changing host]
[19:20:46] -!- rigid has quit [Remote host closed the connection]
[19:21:25] -!- rigid has quit [Changing host]
[19:24:42] -!- rigid has quit [Client Quit]
[19:25:37] -!- rigid has quit [Changing host]
[19:41:58] <terkaa> seb_kuzminsky: Did you find time to check my attempt of coding?
[19:42:07] <terkaa> Was it absolutely horrifying?
[19:42:10] <jepler> terkaa: seb_kuzminsky is away for a week
[19:42:28] <terkaa> Oh ok.
[19:42:51] <jepler> Looking at my logs I don't think he mentioned having a chance to look at your code.
[19:43:08] <jepler> I think all he said was
[19:43:08] <jepler> 08:41:58 <seb_kuzminsky> terkaa: yeah that's on the right track
[19:43:54] <terkaa> Yes that was comment for my git learning
[19:46:55] <jepler> + block->p_number == -1.0 ? settings->cycle_p : block->p_number;
[19:47:38] <jepler> for almost all letters, there is a _flag variable. New code is better checking block->p_flag rather than (block->p_number == -1.0)
[19:47:41] -!- rigid has quit [Quit: NO WINE, NO WIFE, NO CARRIER]
[19:47:59] <jepler> you have done a good job of following the style of nearby code, I appreciate that.
[19:49:34] <jepler> lots of changed/added lines have extra whitespace at the end, I don't like that as much. "git rebase --whitespace=fix" can automatically fix this for you.
[19:50:18] <terkaa> Basically that is mostly Michael Haberlers old work(from 2013). I just modified it to work with current master and added Disable/enable speed/feed overrides
[19:50:23] <jepler> Without understanding what the new functionality *DOES* I think it all looks pretty reasonable.
[19:50:47] <terkaa> thank you for whitespace stripping tip
[19:51:15] <terkaa> It adds G84/G74 floating tapping cycles
[19:51:42] <terkaa> and possibility to enable/disable wait for spindle_at_speed before doing feed move
[19:52:20] <jepler> formerly it always waited?
[19:52:26] <terkaa> yes
[19:53:12] <terkaa> and that does not work with floating tapping. Because at the bottom when reversing spindle dir we need to start feed right away
[19:53:22] <jepler> cradek: do you want to have an opinion about this? It's
https://github.com/terkaa/linuxcnc master branch
[19:54:05] <jepler> terkaa: you've run the cycle on a real machine and it works, correct?
[19:54:06] <cradek> terkaa already fixed the problems I spotted regarding overrides
[19:54:29] <jepler> cradek: great to hear!
[19:54:38] <terkaa> jepler: Yes we have run it many days :)
[19:55:10] <cradek> terkaa: does your machine have a spindle-at-speed hooked up?
[19:55:26] <terkaa> cradek: Yes it does.
[19:55:29] <cradek> the part I worry about the most is breaking that and not noticing (because we have no test coverage)
[19:55:39] <cradek> great - the waiting still works as expected?
[19:56:30] <terkaa> Yes if I remove that wire physically feeds wont start
[19:56:46] <cradek> great
[19:56:48] <jepler> that's a good test, hard to put in the autmatic testsuite though
[19:56:58] <cradek> yeah - I'm glad you tried it
[19:57:00] <jepler> terkaa: are you comfortable enough with git to do the rebase to fix the whitespace?
[19:57:19] <terkaa> jepler: I can try my best
[19:57:37] <jepler> terkaa: OK, please do, and then create a pull request
[19:57:48] <terkaa> jepler: ok
[19:57:49] <jepler> let us know if you run into any trouble.
[19:58:56] -!- ve7it [ve7it!~LawrenceG@S010648f8b3c3bc3b.pk.shawcable.net] has joined #linuxcnc-devel
[19:59:28] <jepler> and thank you for your work!
[20:00:54] <terkaa> That is no problem. We need this on our machine and once it is in master, I can follow latest updates
[20:01:04] <terkaa> I got:Current branch master is up to date, rebase forced.
[20:01:04] <terkaa> First, rewinding head to replay your work on top of it...
[20:01:05] <terkaa> Fast-forwarded master to refs/remotes/origin/master.
[20:01:20] <terkaa> does that sound correct?
[20:03:08] <jepler> not quite
[20:03:30] <terkaa> hmmm....
[20:03:42] <jepler> do you have the linuxcnc github as the "upstream" remote?
[20:03:53] <jepler> or do you just have "origin" remote, which is your own github fork?
[20:04:26] <jepler> ("git remote" will list all the remotes you have)
[20:05:02] <jepler> (if you don't feel like learning that much git / github right this second, it's fine, I can do this "rebase" myself that I am requesting)
[20:05:12] <terkaa> [core]
[20:05:13] <terkaa> repositoryformatversion = 0
[20:05:13] <terkaa> filemode = true
[20:05:13] <terkaa> bare = false
[20:05:13] <terkaa> logallrefupdates = true
[20:05:13] <terkaa> [remote "origin"]
[20:05:17] <terkaa> url =
https://github.com/terkaa/linuxcnc.git
[20:05:19] <terkaa> fetch = +refs/heads/*:refs/remotes/origin/*
[20:05:21] <terkaa> [branch "master"]
[20:05:23] <terkaa> remote = origin
[20:05:25] <terkaa> merge = refs/heads/master
[20:05:27] <terkaa> [remote "upstream"]
[20:05:29] <terkaa> url = git://git.linuxcnc.org/git/linuxcnc.git
[20:05:31] <terkaa> fetch = +refs/heads/*:refs/remotes/upstream/*
[20:05:54] <jepler> OK, so you do have "upstream", that's good
[20:06:05] <jepler> try this as your rebase commandline: git rebase --whitespace=fix upstream/master
[20:06:30] <jepler> you should see:
[20:06:30] <jepler> First, rewinding head to replay your work on top of it...
[20:06:31] <jepler> Applying: G84/G74 canned cycles tests
[20:06:31] <jepler> Applying: Add G74/G84 floating tap cycles;
[20:06:43] <terkaa> First, rewinding head to replay your work on top of it...
[20:06:43] <terkaa> Applying: G84/G74 canned cycles tests
[20:06:43] <terkaa> Applying: Add G74/G84 floating tap cycles;
[20:06:50] <terkaa> yep it is same now
[20:07:59] <jepler> OK, now you can push with "git push -f". You have to say "-f" (force), because in this case you are modifying changes that you had already published with "git push".
[20:09:03] <jepler> looks like you did so already?
[20:09:14] <terkaa> Yes
[20:09:28] -!- skunkworks_ [skunkworks_!~skunkwork@68-115-41-210.static.eucl.wi.charter.com] has joined #linuxcnc-devel
[20:09:57] <jepler> at
https://github.com/terkaa/linuxcnc you can click "create pull request" and it should guide you through the process
[20:10:18] <jepler> first it will show you a page where you are "comparing changes", if that looks right then you "create pull request" a *second* time
[20:10:40] <jepler> then you fill in the title and description, and click "Create pull request" a *third* time. That's the last time.
[20:12:48] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15terkaa opened pull request #210: Adds G84/G74 Floating Tapping Cycles and Possibility to ignore Spindle_at_speed before feed move (06master...06master) 02
https://github.com/LinuxCNC/linuxcnc/pull/210
[20:13:07] -!- kingarmadillo has quit [Ping timeout: 258 seconds]
[20:14:22] <jepler> assuming the checks on travis-ci pass, cradek or I will merge it soon.
[20:14:46] <terkaa> Ok.
[20:16:40] <terkaa> jthornton?
[20:19:20] -!- bpuk [bpuk!~bpuk@boopotter.plus.com] has joined #linuxcnc-devel
[20:21:10] -!- andypugh [andypugh!~andypugh@cpc14-basl11-2-0-cust1010.20-1.cable.virginm.net] has joined #linuxcnc-devel
[20:22:12] <andypugh> cradek: I think you are right that Type1 requires arcs <=90 degrees. But I am more interested in the fun parts of Type2
[20:23:27] <cradek> yeah, the geometry gets interesting
[20:23:43] <cradek> and gouge prevention
[20:23:50] <jepler> *** /home/travis/build/LinuxCNC/linuxcnc/tests/interp/g81/g19/g99: FAIL: result differed from expected
[20:24:02] <cradek> oops
[20:24:13] <jepler> terkaa: ^^ I think these changes in other tests are harmless but I'm not sure
[20:24:24] <andypugh> Is there a good reason not to merge the patch as-is? As long as it is undocumented people can’t complain if it doesn’t work :-)
[20:24:26] <jepler> many places there are two new canon calls to ENABLE_FEED_OVERRIDE and ENABLE_SPEED_OVERRIDE
[20:24:50] <terkaa> jepler: Yes I saw that...
[20:25:16] <cradek> hmm that smells suspicious, unless they were wrong before
[20:25:48] <jepler> cradek: I *think* it's OK...
[20:25:59] <jepler> now all(?) canned cycles save and restore the feed and speed override flags
[20:26:09] <terkaa> Yes
[20:26:10] <jepler> just like they all saved and restored the motion control mode before
[20:26:33] <cradek> aha
[20:26:57] <jepler> several sites, such as in Interp::convert_cycle_xy
[20:26:58] <cradek> wait, why?
[20:27:00] -!- pragmaticus has quit [Ping timeout: 250 seconds]
[20:27:20] <terkaa> I tried also to pass previous state to G84/G74 function only.
[20:27:20] <cradek> most cycles should obey and not mess with those, right?
[20:27:33] <jepler> because Interp::convert_cycle_g74_g84 does
[20:27:49] <terkaa> But I got warnings about variable defined but never used
[20:28:03] -!- marshmn has quit [Ping timeout: 252 seconds]
[20:28:12] <jepler> this save/restore could be moved into Interp::convert_cycle_g74_g84 couldn't it?
[20:29:01] <terkaa> GET_EXTERNAL_FEED_OVERRIDE_ENABLE() function did not work from
[20:29:07] <terkaa> Interp::convert_cycle_g74_g84
[20:29:17] <terkaa> It always returned 1
[20:30:39] <terkaa> I could not figure out why
[20:31:45] <jepler> that's very curious
[20:33:02] <terkaa> Then I tried passing states to of overrides to that function. But compiler reported warnings about variable defined but never used... So I ended up with this solution. But it seems that it needs some more work
[20:33:47] <terkaa> Because it messes up tests of another canned cycles
[20:34:44] <jepler> we could choose to accept the changes to the other tests, I don't think they're *wrong* they are just different than before
[20:35:12] <cradek> how do I see the difference?
[20:35:33] <jepler> no actually it *is* wrong
[20:35:39] <jepler> let me double check ...
[20:36:15] <jepler> here's what I get that I think is wrong:
http://paste.ubuntu.com/23487236/
[20:36:46] <jepler> 27/28 shouldn't enable the overrides
[20:36:49] <cradek> I agree that is wrong
[20:37:26] <jepler> this is a case that was not checked by the tests, in part because before now a canned cycle never changed these flags
[20:37:28] <terkaa> That is true
[20:38:08] <jepler> hmm double hmm
[20:38:18] <jepler> that could be a bug in the "rs274" program's saicanon though
[20:38:21] <jepler> src/emc/sai/saicanon.cc:800:int GET_EXTERNAL_FEED_OVERRIDE_ENABLE() {return 1;}
[20:38:30] <jepler> that implementation of GET_FEED_OVERRIDE_ENABLE is not very good
[20:38:36] <cradek> doh
[20:41:55] <jepler> does GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE really correspond with DISABLE_SPEED_OVERRIDE ?
[20:42:15] <jepler> unfortunate naming choice if so
[20:42:32] <terkaa> yes it does and it is confusing
[20:43:40] <terkaa> same with GET_EXTERNAL_FEED_OVERRIDE / ENABLE_FEED_OVERRIDE
[20:44:45] <jepler> the implementation of GET_EXTERNAL_FEED_OVERRIDE_ENABLE and GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE for task (emccanon.cc) looks right
[20:45:08] <jepler> so if your testing found that you were always getting 1/true for these GET_EXTERNALs, it is explained if you were using the rs274 standalone interpreter
[20:46:59] <terkaa> I tried using simulation with Axis. I had same code:
[20:47:00] <terkaa> save_feed_override_enable = GET_EXTERNAL_FEED_OVERRIDE_ENABLE();
[20:47:00] <terkaa> save_spindle_override_enable = GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE();
[20:47:11] <jepler> yeah AXIS has a bad implementation too
[20:47:15] <cradek> so we could fix sai and put it before terkaa's commit and it'll fix the tests?
[20:47:40] <jepler> cradek: no, the tests will still still fail due to differences
[20:48:25] <cradek> but you wouldn't get lines 27/28 when you do that thing
[20:48:45] <jepler> yeah *that* is fixed
[20:49:27] <terkaa> I can try to modify code so that these are inside Interp::convert_cycle_g74_g84 function
[20:49:44] <jepler> https://github.com/LinuxCNC/linuxcnc/commit/b624266abc220ef55b32bfe86a2cc4191077d879 https://github.com/LinuxCNC/linuxcnc/commit/d34932b97b2812d1246d67cccae44ccb66a2f73e
[20:49:51] <terkaa> But I am afraid it always enables speed/feed overrides
[20:50:32] <jepler> the first commit fixes GET_EXTERNAL_FEED_OVERRIDE_ENABLE() and GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE() for rs274 sai
[20:50:43] <cradek> yay, thank you
[20:50:44] <jepler> so test results will better match what will actually happen in task
[20:51:07] <jepler> then
https://github.com/LinuxCNC/linuxcnc/commit/d34932b97b2812d1246d67cccae44ccb66a2f73e which I didn't test very thoroughly moves the save/restore of the overrides into Interp::convert_cycle_g74_g84
[20:51:54] <jepler> it changes the order of the SET_MOTION_CONTROL_MODE in the g74/g84 tests but it makes it so all the other tests pass without changing their expected results
[20:52:33] <jepler> but now it makes me wonder if we should make sure and run the canned cycle tests (at least g74/g84) with both m48 and m49 settings
[20:53:52] <jepler> READ => m49
[20:53:52] <jepler> 26 N..... DISABLE_FEED_OVERRIDE()
[20:53:52] <jepler> 27 N..... DISABLE_SPEED_OVERRIDE()
[20:53:52] <jepler> READ => g84 x1 y1 z-1 r1
[20:53:53] <jepler> ...
[20:53:56] <jepler> 41 N..... DISABLE_FEED_OVERRIDE()
[20:53:56] <jepler> 42 N..... DISABLE_SPEED_OVERRIDE()
[20:54:10] <jepler> that looks good testing by hand
[20:54:14] -!- rigid has quit [Changing host]
[20:56:24] -!- GJdan has quit [Quit: WeeChat 1.7-dev]
[20:56:42] <bpuk> andypugh: which of the g71 patches did you fixup from the 2012 thread?
[20:57:21] <andypugh> Whichever one the link in the first message was to
[20:57:47] <terkaa> jepler: This is how I tried it first. I cannot understand why it did not work. What happens with m48?
[20:58:01] <andypugh> bpuk: So,
http://www.bpuk.org/linuxcnc/g71-patch-1-initial-feedback-mod.diff
[20:58:29] <bpuk> andypugh: it's been 4 years, and I can't remember what I changed between mods - but the latest was
http://bpuk.org/linuxcnc/g71-patch-2-initial-feedback-mod2.diff
[20:58:47] <andypugh> Hmm, OK
[20:58:55] -!- rigid has quit [Client Quit]
[20:59:24] <jepler> terkaa: discovering the implementation of GET_EXTERNAL_FEED_OVERRIDE and GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE in rs274 sai was bad explains that though
[20:59:37] <andypugh> Is that a diff from patch1 or a diff from master?
[20:59:55] <bpuk> looks like a diff from master at the time
[20:59:55] <jepler> doesn't it?
[21:00:28] <andypugh> It might take someone better at git than me to merge them
[21:00:34] <terkaa> jepler: Yes. Also I had restoring of states in incorrect place
[21:01:11] <bpuk> I'm comparing the diffs by hand at the moment to see if there were any major changes - so far it's all error messages
[21:01:21] <terkaa> inside Case: Plane XX
[21:01:56] -!- rigid has quit [Changing host]
[21:02:03] <terkaa> But now it is like it should be IMHO
[21:02:22] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jepler commented on issue #210: I suggest moving the restores of the override state into the g74/g84-specific code:... 02
https://github.com/LinuxCNC/linuxcnc/pull/210#issuecomment-261070529
[21:02:28] <jepler> terkaa: OK, my change makes sense to you then?
[21:02:41] <terkaa> jepler: Absolutely
[21:03:14] -!- rigid has quit [Client Quit]
[21:03:49] <skunkworks> bpuk, good to see you!
[21:05:06] -!- rigid has quit [Changing host]
[21:05:21] -!- b_b has quit [Remote host closed the connection]
[21:05:36] <jepler> hm now I'm surprised by something else..
[21:06:00] <jepler> https://github.com/LinuxCNC/linuxcnc/commit/d34932b97b2812d1246d67cccae44ccb66a2f73e#diff-3900a70bfb5b0db5691f293c4b5c7539R74
[21:06:10] -!- rigid has quit [Remote host closed the connection]
[21:06:19] <jepler> it adds some speed/feed override enables where they didn't exist before!
[21:07:06] <jepler> and removes some from where they were before
https://github.com/LinuxCNC/linuxcnc/commit/d34932b97b2812d1246d67cccae44ccb66a2f73e#diff-eb388368c7bcfe43d093b05fcd618dfaR17
[21:07:20] <jepler> afk
[21:07:55] -!- rigid has quit [Changing host]
[21:08:04] -!- rigid has quit [Remote host closed the connection]
[21:08:05] <bpuk> thanks skunkworks
[21:09:06] <bpuk> ok, it looks like there were a few important changes between the two patches mentioned - daft things like checking the spindle is started, and a bit of a refactor moving towards having an arbitrary profile that can be used for any canned cycle (at least that was the idea)
[21:09:52] -!- rigid has quit [Changing host]
[21:09:52] <bpuk> and a possible fix for the odd retract too
[21:10:47] -!- rigid has quit [Client Quit]
[21:15:08] <terkaa> This is not correct test
[21:16:01] <terkaa> this is G81 drilling cycle test
[21:16:48] <terkaa> there is no spindle counterclockwise, no dwell and there is traverse movement that should be feed
[21:17:34] -!- skunkworks has quit [Read error: Connection reset by peer]
[21:17:41] <terkaa> Should be like this:
[21:17:42] <terkaa> N..... STRAIGHT_TRAVERSE(1.0000, 1.0000, 1.0000, 0.0000, 0.0000, 0.0000)
[21:17:42] <terkaa> N..... DISABLE_FEED_OVERRIDE()
[21:17:42] <terkaa> N..... DISABLE_SPEED_OVERRIDE()
[21:17:42] <terkaa> N..... STRAIGHT_FEED(1.0000, 1.0000, -1.0000, 0.0000, 0.0000, 0.0000)
[21:17:42] <terkaa> N..... STOP_SPINDLE_TURNING()
[21:17:43] <terkaa> N..... START_SPINDLE_COUNTERCLOCKWISE()
[21:17:45] <terkaa> N..... DWELL(0.0000)
[21:17:47] <terkaa> N..... STRAIGHT_FEED(1.0000, 1.0000, 2.0000, 0.0000, 0.0000, 0.0000)
[21:17:49] <terkaa> N..... STOP_SPINDLE_TURNING()
[21:17:53] <terkaa> N..... START_SPINDLE_CLOCKWISE()
[21:18:28] <terkaa> that is for g84/g17/g98
[21:19:27] <cradek> bpuk: thanks for coming back and still being interested in this :-)
[21:19:55] <bpuk> thank andy - he poked me ;)
[21:20:47] <bpuk> I have to admit - I'm looking at some of the code and asking myself 'what was I thinking'
[21:21:23] <andypugh> bpuk: Did you see cradek’s comments here? (Not a very convenient format to read comments in)
https://github.com/LinuxCNC/linuxcnc/commit/0da9a50f30bb575d557b6617fa0fb0b228216f43#commitcomment-19846413
[21:21:46] <cradek> there's also a new mailing list thread
[21:21:50] <cradek> in -devel
[21:22:13] -!- skunkworks_ has quit [Ping timeout: 248 seconds]
[21:23:14] <bpuk> andypugh: I did - which was why I asked which patch you'd started from
[21:23:23] <jepler> terkaa: well for now what I'm going to do is put the saicanon.cc change on our master branch.
[21:23:39] <bpuk> cradek: Yup, I've caught up on that thread
[21:24:08] -!- rigid has quit [Changing host]
[21:24:17] <bpuk> I think I'll pull that branch, and create a new diff to bring it up to my latest patch if that's ok?
[21:24:21] <terkaa> jepler: ok
[21:24:21] -!- rigid has quit [Remote host closed the connection]
[21:24:36] <jepler> terkaa: write us a note on the pull request after you've updated your master branch in a way that allows all tests to pass. Remember that you can "git fetch upstream; git rebase upstream/master" to have my fix to rs274 saicanon in your branch..
[21:25:02] -!- rigid has quit [Changing host]
[21:25:23] <cradek> bpuk: that's great, you could even make a pull request on it directly
[21:25:45] <jepler> terkaa: makes sense?
[21:25:52] <andypugh> bpuk: Yes, that seems like the best way.
[21:26:04] <terkaa> jepler: yes it does
[21:27:13] <andypugh> bpuk: I am actually working on a version using remap. But _not_ because I don’t think it belongs in the C++ code, because I am interested in the logic of a type-2 version.
[21:27:39] <andypugh> And it’s just easier and quicker to fiddle with Python than C++
[21:28:33] <bpuk> andypugh: If you speak python, that's probably the best way.
[21:28:53] <andypugh> Well, I speak C better than Python, but C++ hardly at all.
[21:29:28] <jepler> C++ is just C with an accent it likes to think of as posh.
[21:29:51] <bpuk> heh. I'm more comfortable with C, or assembler - I've never got my head around the more modern languages properly
[21:30:00] <andypugh> Yes, I can read it, but not write it. Like I can understand posh English, but not speak it.
[21:30:11] <pcw_mesa> andypugh not sure if you got my irc response: the -M encoder flag works fine
[21:30:23] <andypugh> pcw_mesa: Great
[21:31:08] <pcw_mesa> I can now unplug my 24 bit SSI encder and plug it back in again and end up in the same place :-)
[21:31:36] <jepler> pcw_mesa: that's super neat
[21:32:16] <pcw_mesa> Yeah you dont always want wrapping enabled
[21:32:49] <pcw_mesa> I did uncover terkaa's DPLL bug
[21:34:03] <KGB-linuxcnc> 03Andy Pugh 05master 73e6860 06linuxcnc fast forward * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=73e6860
[21:34:24] <jepler> pcw_mesa: is it in the FPGA or in the hal component?
[21:34:42] <pcw_mesa> hal
[21:35:01] <andypugh> The DPLL bug?
[21:35:10] <andypugh> Oh, I assumed it was in the firmware
[21:35:23] <pcw_mesa> timer setting doesn't work right
[21:35:26] <jepler> pcw_mesa: in that case tell us more
[21:35:49] <KGB-linuxcnc> 03Jeff Epler 05master 2b678aa 06linuxcnc 10src/emc/sai/saicanon.cc rs274 sai: Properly implement two GET_EXTERNALs * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=2b678aa
[21:36:17] <pcw_mesa> well it works right in all my example files but mr terkas did some oddball stuff that exposed a bug
[21:36:41] -!- kingarmadillo has quit [Ping timeout: 258 seconds]
[21:36:56] <bpuk> bah, need to reboot
[21:37:03] -!- bpuk has quit []
[21:37:05] <jepler> that's better than a bug that affects all or default configs at least
[21:37:23] <pcw_mesa> if you set timer 1 it works
[21:37:25] <pcw_mesa> if you set timer 2 but never set timer 1 timer 2 is never updated
[21:37:37] <pcw_mesa> same for 3,4
[21:39:20] <pcw_mesa> the default timer values (+100 usec) are not written correctly ether
[21:39:47] <jepler> OK, I'll open a github issue with that info so it doesn't get forgotten
[21:40:03] <pcw_mesa> timer 1,2 share a 32 bit register as do 3,4
[21:40:09] <jepler> yeah I see that in the source already
[21:40:23] <jepler> buff = (rtapi_u32)((-*hm2->dpll.pins->time2_us / period_us) * 0x10000) << 16
[21:40:26] <jepler> | (rtapi_u32)((-*hm2->dpll.pins->time1_us / period_us) * 0x10000);
[21:40:29] <jepler> if (buff != hm2->dpll.timer_12_written){
[21:40:36] <jepler> but I still didn't spot the bug yet
[21:40:49] <pcw_mesa> they probably should use a shadow register and always write all
[21:41:30] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jepler opened issue #211: hm2 dpll: reportedly, setting even-numbered timers doesn't work 02
https://github.com/LinuxCNC/linuxcnc/issues/211
[21:42:13] <pcw_mesa> used raw-read to see what was going on
[21:42:40] <jepler> afk again. I hope to get at least one solid day during the holiday weekend to work on hostmot2 though.
[21:42:44] <pcw_mesa> quite weird
[21:43:03] <jepler> pcw_mesa: so if you set 1 and 2, it does raw-read back as expected?
[21:43:13] <pcw_mesa> yes
[21:43:16] <jepler> (by setps before starting hal threads I imagine)
[21:43:42] <pcw_mesa> naturally all my test code either just used timer 1 or setp all timers
[21:44:13] <pcw_mesa> and those both work fine
[21:53:28] -!- bpuk [bpuk!~bpuk@boopotter.plus.com] has joined #linuxcnc-devel
[21:56:55] <terkaa> jeppler: Made corrections as suggested
[22:12:15] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15terkaa commented on issue #210: Issues should be fixed now 02
https://github.com/LinuxCNC/linuxcnc/pull/210#issuecomment-261088929
[22:17:10] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15terkaa commented on issue #210: It seems I still have some work with Expected test...... 02
https://github.com/LinuxCNC/linuxcnc/pull/210#issuecomment-261090138
[22:17:21] -!- terkaa has quit [Quit: Leaving]
[22:23:35] -!- BeachBumPete [BeachBumPete!~IceChat9@2601:589:8201:bbc0:143c:f72c:e2f1:8056] has joined #linuxcnc-devel
[22:24:03] -!- BeachBumPete [BeachBumPete!~IceChat9@2601:589:8201:bbc0:143c:f72c:e2f1:8056] has parted #linuxcnc-devel
[22:29:20] <bpuk> I always forget how many dependencies there are to compile linuxcnc
[22:41:17] -!- kingarmadillo has quit [Ping timeout: 240 seconds]
[22:50:56] -!- marshmn has quit [Ping timeout: 260 seconds]
[22:51:15] -!- zeeshan [zeeshan!~kvirc64@CPE84948c379051-CM84948c379050.cpe.net.cable.rogers.com] has joined #linuxcnc-devel
[23:15:23] <andypugh> bpuk: Do you know the checkbuilddeps way to get the list?
[23:16:16] <andypugh> http://wiki.linuxcnc.org/cgi-bin/wiki.pl?Installing_LinuxCNC#Resolving_outstanding_build_dependencies
[23:24:03] <bpuk> yup, got it checked out and built - will start patching tomorrow
[23:24:18] <bpuk> and try to think of evil gcode that will break it
[23:37:01] <andypugh> cradek (I think) listed some things. Arcs > 180 seem like one thing to check.
[23:46:30] -!- skunkworks_ [skunkworks_!~skunkwork@str-broadband-ccmts-ws-26.dsl.airstreamcomm.net] has joined #linuxcnc-devel
[23:47:03] -!- bpuk has quit []
[23:54:47] -!- skunkworks_ has quit [Read error: Connection reset by peer]
[23:58:56] -!- skunkworks [skunkworks!~skunkwork@str-broadband-ccmts-ws-26.dsl.airstreamcomm.net] has joined #linuxcnc-devel
[23:59:29] <skunkworks> zlog
[23:59:29] <zlog> skunkworks: Log stored at
http://tom-itx.no-ip.biz:81/~tom-itx/irc/logs/%23linuxcnc-devel/2016-11-16.html