EMC: 03jepler 07v2.4_branch * r9c59cf5a5bfe 10/src/emc/task/emctaskmain.cc: make "step from start" run+pause, not run+step+pause
I have a patch file that adds support for the 3-phase PWMs and onboard LEDs to the Hostmot2 driver. What should I do with it next?
a few options:
1) email it to seb
2) email it to the devel list (if it's not too big) or stick it on the wiki, so others can look at it
3) make a branch for it in git
and push to the main repo
andypugh doesn't have push access so that option's no good
I asked Seb if he would look at it, but have had no reply. Does anyone know if he is around?
I haven't seen seb around much
he's quite busy
I'd create a commit with git commit (or in git gui), then use git format-patch to make a file with the patch, then send it to the mailing list (as an attachment if I didn't trust my mail program to handle patches inline)
(and congrats for getting it working!)
Should I split it into two patches? One for LEDs and one for 3P-PWMs?
I thought you might say that.
(Hmm, I wonder how?)
"git gui" can help by staging individual lines or chunks
if you already made a commit with everything in it, then you can use the "amend commit" button by the place where you type the change message
stgit might be handy too
I don't think what I did counts as making a commit, I just copied the entire source tree of my working installation, and then started fiddling.
if you didn't "git commit" or use the git gui "commit" button then you almost certainly didn't create a commit
Well, at that point I didn't really expect to get anywhere, so I was just messing around and looking at the source.
A month ago I had never even programmed in C, git is yet another mystery.
that's the minus side. on the plus side, it sounds like you pick up new things pretty quickly.
are the changes you made inside a git clone of emc2, or are they in a copy of the source that is not a git clone?
It looks like git gui just remastered my devel directory. Does it make sense to hand-edit the patch file I have into two seperate ones then patch two branches?
It looks like my emc-dev directory is now 2.5~pre when it was 2.4~pre
(Not a problem, I was going to do that anyway soon).
Looking in the copy that I made and did the changes in, it looks like Git has already spotted the changed files.
for the short term if you want to just send the patch with both things to the list that would be fine
I think that will be easier from where we are now.
but for the future you may find it useful to learn how to use some more of git -- for instance, until you've commited your changes, you can't "git pull" to get changes from other developers..
(a git commit sent with git format-patch has advantages over a plain patch, like it will automatically track that *you* wrote that code no matter who who actually puts the commit in the official version)
bbl, heading home from work